Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ad type instabilities in new zygote #202

Merged
merged 1 commit into from
Jan 11, 2025
Merged

fix ad type instabilities in new zygote #202

merged 1 commit into from
Jan 11, 2025

Conversation

Jutho
Copy link
Owner

@Jutho Jutho commented Jan 10, 2025

No description provided.

@Jutho
Copy link
Owner Author

Jutho commented Jan 10, 2025

CI failures seem CUDA / BFloat16s.jl related (still?) Maybe something is stopping these packages to be updated to the latest version.

lkdvos
lkdvos approved these changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As failures are unrelated, I would merge this as is, and investigate the rest afterwards again

@Jutho Jutho merged commit 2adad27 into master Jan 11, 2025
16 of 18 checks passed
@Jutho Jutho deleted the jh/adfix branch January 11, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkdvos lkdvos lkdvos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jutho @lkdvos